Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 09/10] mtd: st_spi_fsm: Provide mask to obtain correct boot device pins | Date | Thu, 22 May 2014 13:47:07 +0200 |
| |
On Thursday 22 May 2014 12:24:07 Lee Jones wrote: > + /* Mask to apply on boot_device_reg */ > + ret = of_property_read_u32(np, "st,boot-device-msk", &boot_device_msk); > + if (ret) > + goto boot_device_fail; > + >
The binding defines this property as "optional", but the driver fails here if it's not provided. I suggest you add a default value here so you can deal with existing dts. The default should be documented in the binding as well.
Arnd
| |