Messages in this thread | | | Date | Thu, 22 May 2014 16:21:29 +0530 | From | Sekhar Nori <> | Subject | Re: [PATCH] i2c: davinci: Add block read functionality for IPMI |
| |
On Friday 02 May 2014 12:19 AM, Murali Karicheri wrote: > Intelligent Plaform Management Interface (IPMI) requires I2C driver > to support block read, where the first byte received from slave is > the length of following data:- > Added length check if the read type is block read (I2C_M_RECV_LEN) > Send NACK/STOP bits before last byte is received > > Signed-off-by: Garrett Ding <g-ding@ti.com> > Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
I tested this on a DA850 using i2cdetect and it did not seem to break anything so:
Tested-by: Sekhar Nori <nsekhar@ti.com>
There are some checks that were triggered in checkpatch. You may want to fix them up.
Thanks, Sekhar
CHECK: Alignment should match open parenthesis #112: FILE: drivers/i2c/busses/i2c-davinci.c:557: + w = davinci_i2c_read_reg(dev, + DAVINCI_I2C_MDR_REG);
CHECK: Alignment should match open parenthesis #115: FILE: drivers/i2c/busses/i2c-davinci.c:560: + davinci_i2c_write_reg(dev, + DAVINCI_I2C_MDR_REG, w);
CHECK: Alignment should match open parenthesis #119: FILE: drivers/i2c/busses/i2c-davinci.c:564: + davinci_i2c_write_reg(dev, + DAVINCI_I2C_MDR_REG, w);
total: 0 errors, 0 warnings, 3 checks, 67 lines checked
| |