Messages in this thread | | | Date | Thu, 22 May 2014 10:24:43 +0100 | From | Ian Abbott <> | Subject | Re: [PATCH 1/2] staging: comedi: addi_apci_1564: move apci1564_di_insn_bits() to addi_apci_1564.c |
| |
On 2014-05-22 01:40, Chase Southwood wrote: > This function is already compliant with the comedi API and is behaving as > comedi core expects. This patch moves it out of > addi-data/hwdrv_apci1564.c and into the driver proper since no further > work needs to be done on it. > > Cc: Ian Abbott <abbotti@mev.co.uk> > Cc: H Hartley Sweeten <hsweeten@visionengravers.com> > Signed-off-by: Chase Southwood <chase.southwood@gmail.com> > --- > drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c | 12 ------------ > drivers/staging/comedi/drivers/addi_apci_1564.c | 12 ++++++++++++ > 2 files changed, 12 insertions(+), 12 deletions(-)
Looks fine, but depends on two series of your patches (4 + 2 patches) being applied to staging-next before this one.
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
| |