lkml.org 
[lkml]   [2014]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 3/3] timerfd: Implement write method
On Thu, May 22, 2014 at 06:43:08AM +0900, Thomas Gleixner wrote:
> On Tue, 29 Apr 2014, Cyrill Gorcunov wrote:
> > +static ssize_t timerfd_write(struct file *file, const char __user *buf,
> > + size_t count, loff_t *ppos)
> > +{
> > + struct timerfd_ctx *ctx = file->private_data;
> > + u64 ticks = 0;
> > +
> > + if (count < sizeof(ticks))
> > + return -EINVAL;
> > +
> > + if (get_user(ticks, (u64 __user *) buf))
> > + return -EFAULT;
> > +
> > + spin_lock_irq(&ctx->wqh.lock);
> > + ctx->ticks = ticks;
>
> So what wakes a potential waiter in read/poll?

Why should it? You mean the scenario when timer is armed then
someone writes nonzero @ticks and we should wake waiters?
The idea was to setup this ticks on timer restore without
waking anyone. If it breaks the logic of timerfd in general,
then sure I need to rework. Hm?


\
 
 \ /
  Last update: 2014-05-24 07:41    [W:0.185 / U:0.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site