Messages in this thread | | | Date | Wed, 21 May 2014 19:51:11 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH v2 2/2] mm/compaction: avoid rescanning pageblocks in isolate_freepages |
| |
On Mon, 19 May 2014, Vlastimil Babka wrote:
> Fix a (spurious) build warning: > > mm/compaction.c:860:15: warning: ‘next_free_pfn’ may be used uninitialized in this function [-Wmaybe-uninitialized] > > Seems like the compiler cannot prove that exiting the for loop without updating > next_free_pfn there will mean that the check for crossing the scanners will > trigger. So let's not confuse people who try to see why this warning occurs. > > Instead of initializing next_free_pfn to zero with an explaining comment, just > drop the damned variable altogether and work with cc->free_pfn directly as > Nayoa originally suggested. >
s/Nayoa/Naoya/
> Suggested-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> > Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
Acked-by: David Rientjes <rientjes@google.com> | |