lkml.org 
[lkml]   [2014]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] mm: non-atomically mark page accessed during page cache allocation where possible -fix
    On Wed, May 21, 2014 at 03:11:42PM -0700, Andrew Morton wrote:
    > On Wed, 21 May 2014 13:09:16 +0100 Mel Gorman <mgorman@suse.de> wrote:
    >
    > > > From: Andrew Morton <akpm@linux-foundation.org>
    > > > Subject: mm/shmem.c: don't run init_page_accessed() against an uninitialised pointer
    > > >
    > > > If shmem_getpage() returned an error then it didn't necessarily initialise
    > > > *pagep. So shmem_write_begin() shouldn't be playing with *pagep in this
    > > > situation.
    > > >
    > > > Fixes an oops when "mm: non-atomically mark page accessed during page
    > > > cache allocation where possible" (quite reasonably) left *pagep
    > > > uninitialized.
    > > >
    > > > Reported-by: Prabhakar Lad <prabhakar.csengg@gmail.com>
    > > > Cc: Johannes Weiner <hannes@cmpxchg.org>
    > > > Cc: Vlastimil Babka <vbabka@suse.cz>
    > > > Cc: Jan Kara <jack@suse.cz>
    > > > Cc: Michal Hocko <mhocko@suse.cz>
    > > > Cc: Hugh Dickins <hughd@google.com>
    > > > Cc: Peter Zijlstra <peterz@infradead.org>
    > > > Cc: Dave Hansen <dave.hansen@intel.com>
    > > > Cc: Mel Gorman <mgorman@suse.de>
    > > > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    > >
    > > Acked-by: Mel Gorman <mgorman@suse.de>
    >
    > What to do with
    > http://ozlabs.org/~akpm/mmots/broken-out/mm-non-atomically-mark-page-accessed-during-page-cache-allocation-where-possible-fix.patch?
    >
    > We shouldn't need it any more. otoh it's pretty harmless. otooh it
    > will hide bugs such as this one.
    >

    Drop it.

    --
    Mel Gorman
    SUSE Labs


    \
     
     \ /
      Last update: 2014-05-22 02:41    [W:4.789 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site