lkml.org 
[lkml]   [2014]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH Resend] driver/core: cpu: initialize opp table
    Date
    On Tuesday, May 20, 2014 08:08:11 AM Viresh Kumar wrote:
    > On 20 May 2014 02:43, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
    > > What about
    > >
    > > if (error)
    > > return error;
    > >
    > > and then you'd save an indentation level?
    >
    > Yes.
    >
    > > Anyway, I find adding of_node* stuff directly to the driver core this way
    > > kind of disgusting as there still are platforms that don't use it.
    > >
    > > Can we have a call to a function that will change into an empty stub on such
    > > platforms here, please?
    >
    > Okay. But can you explain a bit more about how and where those stubs
    > would be implemented?

    In a header file included by cpu.c. Something like

    #if defined(CONFIG_OF) && defined(CONFIG_PM_OPP)
    <function header>
    #else
    static inline <stub>
    #endif


    --
    I speak only for myself.
    Rafael J. Wysocki, Intel Open Source Technology Center.


    \
     
     \ /
      Last update: 2014-05-22 02:21    [W:4.120 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site