Messages in this thread | | | Date | Wed, 21 May 2014 16:31:13 -0400 (EDT) | Subject | Re: [patch net-next] net: ipv6: trigger action when setting conf.all sysctls | From | David Miller <> |
| |
From: Cong Wang <cwang@twopensource.com> Date: Wed, 21 May 2014 10:35:17 -0700
> On Mon, May 19, 2014 at 10:09 AM, Milos Vyletel <milos.vyletel@gmail.com> wrote: >> As it is right now most of these tunables don't do anything - they don't >> set any interface specific settings to the desired value and they don't >> take precedence before device specific settings in most cases. >> >> Documentation/networking/ip-sysctl.txt defines them to be: >> conf/all/*: >> Change all the interface-specific settings. >> >> but that is not really the case. >> > > I don't think it's a good idea, it enforces interface specific changes. > > You need to mimic what IPv4 conf does (if it hasn't done yet), something > like below: > > #define IN_DEV_MAXCONF(in_dev, attr) \ > (max(IPV4_DEVCONF_ALL(dev_net(in_dev->dev), attr), \ > IN_DEV_CONF_GET((in_dev), attr)))
Agreed.
| |