lkml.org 
[lkml]   [2014]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv5 09/10] DTS: ARM: OMAP3-N900: Add SSI support
* Sebastian Reichel <sre@kernel.org> [140521 11:26]:
> Hi,
>
> On Mon, May 19, 2014 at 05:35:39PM -0700, Tony Lindgren wrote:
> > * Tony Lindgren <tony@atomide.com> [140514 14:57]:
> > > * Sebastian Reichel <sre@kernel.org> [140510 09:40]:
> > > > Add SSI device tree data for OMAP3 and Nokia N900.
> > >
> > > Picking this patch into omap-for-v3.16/dt thanks.
> >
> > Just noticed that this patch seems to somehow break idle
> > modes on n900, so dropping both dts changes for now.
> >
> > Basically the n900 debug LEDs won't ever go off with
> > these two dts patches enabled, even without the modem
> > drivers loaded. I did not dig deeper, but it's probably
> > something related to hwmod using this data for some
> > settings.
>
> Is hwmod data interpreted at all without the DT entries?

Yes for autoidling unused devices. We parse that with
omap_device_build_from_dt().

> The hwmod data may be wrong. The information from commit
> 398917ce161e10d3c66afaefdb89c73c64c4b02d was simply
> interpolated from all information I found. The OMAP3
> public TRM does not contain *any* information about the
> ssi IP-Core.

It's probably something with the sysc or idlemodes that
keeps things from idling. Maybe wrong address? Or wrong
flags? I'm pretty sure it was the first .dts patch out of
these two as the second one alone did not apply.

> > Sorry did not notice it earlier as I did not have the
> > PM regression fix patches merged with my testing branch.
>
> I hoped to see working modem in 3.16, which will probably
> be used for the next Debian stable :(

That would indeed be nice, let's try to debug it as we
still have few days. I'm finally able to test for PM
regressions with DT patches, too bad we did not have
that earlier because of multiple issues.

Anyways, this dts issue should not prevent merging the
driver changes, I'm all for that!

Regards,

Tony


\
 
 \ /
  Last update: 2014-05-21 21:21    [W:0.090 / U:5.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site