Messages in this thread | | | Date | Sat, 3 May 2014 08:58:31 +0800 | Subject | Re: [PATCH] netdev: pktgen xmit packet through vlan interface | From | Zhouyi Zhou <> |
| |
Thank Sergei for reviewing.
I think On Sat, May 3, 2014 at 12:18 AM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote:
>> + >> + if (pkt_dev->clone_skb && is_vlan_dev(odev)) { >> + nskb = skb_clone(pkt_dev->skb, GFP_ATOMIC); >> + ret = -ENOMEM; >> + if (nskb) >> + ret = (*xmit)(nskb, odev); if (is_vlan_dev(odev) && pkt_dev->clone_skb) { nskb = skb_clone(pkt_dev->skb, GFP_ATOMIC); ret = -ENOMEM; if (nskb) ret = (*xmit)(nskb, odev); } > and
case NETDEV_TX_LOCKED: case NETDEV_TX_BUSY: /* Retry it next time */ atomic_dec(&(pkt_dev->skb->users)); if (is_vlan_dev(odev) && pkt_dev->clone_skb && nskb) kfree_skb(nskb); else atomic_dec(&(pkt_dev->skb->users));
is better, because is_vlan_dev(odev) is probably in read most cache line.
Zhouyi
| |