lkml.org 
[lkml]   [2014]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] netdev: pktgen xmit packet through vlan interface
    From
    Thank Sergei for reviewing.

    I think
    On Sat, May 3, 2014 at 12:18 AM, Sergei Shtylyov
    <sergei.shtylyov@cogentembedded.com> wrote:

    >> +
    >> + if (pkt_dev->clone_skb && is_vlan_dev(odev)) {
    >> + nskb = skb_clone(pkt_dev->skb, GFP_ATOMIC);
    >> + ret = -ENOMEM;
    >> + if (nskb)
    >> + ret = (*xmit)(nskb, odev);
    if (is_vlan_dev(odev) && pkt_dev->clone_skb) {
    nskb = skb_clone(pkt_dev->skb, GFP_ATOMIC);
    ret = -ENOMEM;
    if (nskb)
    ret = (*xmit)(nskb, odev);
    }
    >
    and

    case NETDEV_TX_LOCKED:
    case NETDEV_TX_BUSY:
    /* Retry it next time */
    atomic_dec(&(pkt_dev->skb->users));
    if (is_vlan_dev(odev) && pkt_dev->clone_skb && nskb)
    kfree_skb(nskb);
    else
    atomic_dec(&(pkt_dev->skb->users));

    is better, because is_vlan_dev(odev) is probably in read most cache line.

    Zhouyi


    \
     
     \ /
      Last update: 2014-05-03 03:21    [W:5.271 / U:0.224 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site