| Date | Fri, 02 May 2014 18:34:52 -0400 | From | Sasha Levin <> | Subject | Re: [PATCH 08/17] mm: page_alloc: Use word-based accesses for get/set pageblock bitmaps |
| |
Hi Mel,
Vlastimil Babka suggested I should try this patch to work around a different issue I'm seeing, and noticed that it doesn't build because:
On 05/01/2014 04:44 AM, Mel Gorman wrote: > +void set_pageblock_flags_mask(struct page *page, > + unsigned long flags, > + unsigned long end_bitidx, > + unsigned long nr_flag_bits, > + unsigned long mask);
set_pageblock_flags_mask() is declared.
> +static inline void set_pageblock_flags_group(struct page *page, > + unsigned long flags, > + int start_bitidx, int end_bitidx) > +{ > + unsigned long nr_flag_bits = end_bitidx - start_bitidx + 1; > + unsigned long mask = (1 << nr_flag_bits) - 1; > + > + set_pageblock_flags_mask(page, flags, end_bitidx, nr_flag_bits, mask); > +}
And used here, but never actually defined.
Thanks, Sasha
|