lkml.org 
[lkml]   [2014]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/17] mm: page_alloc: Use word-based accesses for get/set pageblock bitmaps
Hi Mel,

Vlastimil Babka suggested I should try this patch to work around a different
issue I'm seeing, and noticed that it doesn't build because:

On 05/01/2014 04:44 AM, Mel Gorman wrote:
> +void set_pageblock_flags_mask(struct page *page,
> + unsigned long flags,
> + unsigned long end_bitidx,
> + unsigned long nr_flag_bits,
> + unsigned long mask);

set_pageblock_flags_mask() is declared.


> +static inline void set_pageblock_flags_group(struct page *page,
> + unsigned long flags,
> + int start_bitidx, int end_bitidx)
> +{
> + unsigned long nr_flag_bits = end_bitidx - start_bitidx + 1;
> + unsigned long mask = (1 << nr_flag_bits) - 1;
> +
> + set_pageblock_flags_mask(page, flags, end_bitidx, nr_flag_bits, mask);
> +}

And used here, but never actually defined.


Thanks,
Sasha


\
 
 \ /
  Last update: 2014-05-03 01:21    [W:0.394 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site