Messages in this thread | | | Date | Fri, 02 May 2014 19:19:49 +0400 | From | Sergei Shtylyov <> | Subject | Re: [PATCH 2/8] sh, irq: Remove irq_reserve_irq calling |
| |
Hello.
On 05/02/2014 03:18 AM, Yinghai Lu wrote:
> in sh calling path: > register_intc_controller > ==> irq_create_identity_mapping/irq_create_strict_mappins > ==>irq_alloc_desc: it will set bits on allocate_irq > ==> intc_register_irq > ==> irq_reserve_irq: set bits again
> so we can kill this irq_reserve_irq calling.
> Signed-off-by: Yinghai Lu <yinghai@kernel.org> > Cc: Simon Horman <horms@verge.net.au> > Cc: Magnus Damm <magnus.damm@gmail.com> > Cc: linux-sh@vger.kernel.org > --- > drivers/sh/intc/core.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-)
> diff --git a/drivers/sh/intc/core.c b/drivers/sh/intc/core.c > index 8f32a13..05118f92 100644 > --- a/drivers/sh/intc/core.c > +++ b/drivers/sh/intc/core.c > @@ -81,11 +81,8 @@ static void __init intc_register_irq(struct intc_desc *desc, > unsigned long flags; > > /* > - * Register the IRQ position with the global IRQ map, then insert > - * it in to the radix tree. > + * insert it in to the radix tree.
It makes sense to convert this comment to one-liner now. I'd also have started it with a capital letter.
> */ > - irq_reserve_irq(irq); > - > raw_spin_lock_irqsave(&intc_big_lock, flags); > radix_tree_insert(&d->tree, enum_id, intc_irq_xlate_get(irq)); > raw_spin_unlock_irqrestore(&intc_big_lock, flags);
WBR, Sergei
| |