Messages in this thread | | | From | David Matlack <> | Date | Mon, 19 May 2014 13:54:02 -0700 | Subject | Re: [PATCH 2/2] staging: slicoss: remove slic_reg_params struct |
| |
On Mon, May 19, 2014 at 12:52 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > > You have to understand that I review a lot of staging patches every day. > Most patches try to remove struct members but the code should still work > exactly as it did before (a clean up). Some patches remove struct > members and the behavior changes. Hopefully it's deliberate and the > changelog mentions that it is a bug fix. If it changes the run time, > and not deliberately then that's a bug. >
Ah I see. This patch does indeed change the behavior. Since I plan to resend the other patch in this series, I'll fix the changelog for this patch as well.
Thanks for the review.
| |