[lkml]   [2014]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [patch] module: static checker complains about negative values
Dan Carpenter <> writes:

> We cap "stat.size" at INT_MAX but we don't check for negative values so
> my static checker complains. At this point, you already have control of
> the kernel and if you start passing negative values here then you
> deserve what happens next.
> On 64 bit systems the vmalloc() will definitely fail. On 32 bit systems
> we truncate the upper 32 bits away so that could succeed. I haven't
> followed it further than that.
> Signed-off-by: Dan Carpenter <>

If vfs_getattr() returns a negative stat.size, we have worse problems.

I'd rather see you sprinkle assertions like that into the code, so we
can make sure that can't happen for any fs's getattr().


 \ /
  Last update: 2014-05-20 04:41    [W:0.027 / U:4.752 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site