[lkml]   [2014]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/7] staging: unisys: move uislib/platform proc entry to debugfs
On Mon, May 19, 2014 at 10:57:08PM +0300, Dan Carpenter wrote:
> On Mon, May 19, 2014 at 09:42:22AM -0500, Romer, Benjamin M wrote:
> > On Sun, 2014-05-18 at 09:49 -0700, Greg KH wrote:
> > > Also, why are these entries moving to debugfs at all? Why are they
> > > needed? Who will use them? Are tools relying on them to be there?
> >
> > The tuning entries are sometimes used to help adjust the behavior of our
> > IO service partitions for better performance.
> That sounds like it really belongs in sysfs instead of debugfs.

Exactly. debugfs files are for "debugging". Consider them files that
your driver can work properly if no one ever touches them.

"tuning" files imply something that has to be touched by users.
Ideally, you would never need such a thing as no one wants to have to
write things to files to make the kernel work better. But if you really
need it, they should be sysfs files, with the needed documentation.


greg k-h

 \ /
  Last update: 2014-05-20 03:41    [W:0.068 / U:0.100 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site