Messages in this thread | | | Date | Mon, 19 May 2014 16:43:01 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc |
| |
On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins <hughd@google.com> wrote:
> Shouldn't FAULT_AROUND_ORDER and fault_around_order be changed to be > the order of the fault-around size in bytes, and fault_around_pages() > use 1UL << (fault_around_order - PAGE_SHIFT)
Yes. And shame on me for missing it (this time!) at review.
There's still time to fix this. Patches, please.
| |