lkml.org 
[lkml]   [2014]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 05/06] staging: crypto: skein: rename macros
On Mon, May 19, 2014 at 12:08:39PM +0300, Dan Carpenter wrote:
> On Mon, May 19, 2014 at 12:09:58PM +0400, Anton Saraev wrote:
> > +/* ignore all asserts, for performance */
> > +#define skein_assert_ret(x, ret_code)
> > +#define skein_assert(x)
>
> Not related to this patch, but defining away asserts like this is a bad
> idea. What if they have side affects like:
>
> skein_assert(foo++ == bar);

Agreed. This driver is definitely a work in progress. If you look at
the history, you'll see that I started with a bit-for-bit copy of a
publicly available reference implementation. After we get the coding
style in shape, there are plenty of other improvements to make.

Thanks for the review.

thx,

Jason.


\
 
 \ /
  Last update: 2014-05-19 16:41    [W:0.065 / U:0.896 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site