lkml.org 
[lkml]   [2014]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] Fix for possible null pointer dereference in node.c
From
Hi

When I run cppcheck find the about 5,000 errors, of these, I selected
the 100 most serious and has made patches. But my ability to immerse
myself in each failure has been limited unfortunately.

Okay, I send it through the scripts instead.


Best regards
Rickard Strandqvist


2014-05-17 20:56 GMT+02:00 Dan Carpenter <dan.carpenter@oracle.com>:
> On Sat, May 17, 2014 at 03:21:56PM +0200, Rickard Strandqvist wrote:
>> Okay, everyone agrees with Dan..?
>>
>
> You can audit it yourself, there are only 4 callers. The
> node_allocate() is total garbage so the second delete_node() is a bit
> complicated to read but it's not that hard.
>
>> I have made a new patch, which does not check if hnode is NULL.
>
> Send it inline so we can use our normal scripts.
>
> regards,
> dan carpenter
>


\
 
 \ /
  Last update: 2014-05-18 18:21    [W:0.052 / U:0.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site