Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 08/20] perf tools: Allow hpp fields to be sort keys | Date | Fri, 16 May 2014 15:29:45 +0900 |
| |
On Thu, 15 May 2014 15:07:28 +0200, Jiri Olsa wrote: > On Mon, May 12, 2014 at 03:28:41PM +0900, Namhyung Kim wrote: >> Add overhead{,_sys,_us,_guest_sys,_guest_us}, sample and period sort >> keys so that they can be selected with --sort/-s option. >> >> $ perf report -s period,comm --stdio >> ... >> # Overhead Period Command >> # ........ ............ ............... >> # >> 47.06% 152 swapper >> 13.93% 45 qemu-system-arm >> 12.38% 40 synergys >> 3.72% 12 firefox >> 2.48% 8 xchat >> >> Acked-by: Ingo Molnar <mingo@kernel.org> >> Signed-off-by: Namhyung Kim <namhyung@kernel.org> >> --- >> tools/perf/ui/hist.c | 9 +++++++-- >> tools/perf/util/sort.c | 39 +++++++++++++++++++++++++++++++++++++++ > > no documentation update.. Documentation/perf-report.txt
Will add.
> > I wonder we want to update report's '-s' option help string.. it's already big ;-)
Right. What about just listing basic/common keys and description like "please refer the man page to the complete list." :)
Thanks, Namhyung
| |