Messages in this thread | | | Date | Thu, 15 May 2014 12:36:56 -0700 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH v5 3/3] CPU hotplug, smp: Flush any pending IPI callbacks before CPU offline |
| |
On Fri, May 16, 2014 at 12:56:11AM +0530, Srivatsa S. Bhat wrote: > On 05/16/2014 12:49 AM, Tejun Heo wrote: > > Hello, > > > > On Fri, May 16, 2014 at 12:44:13AM +0530, Srivatsa S. Bhat wrote: > >> /* > >> + * flush_smp_call_function_queue - Flush any pending smp-call-function > > > > Don't we need a blank line here? > > Hmm? That sentence continues on the next line, hence I didn't add any blank > line there.
Tejun might be wanting this to be a docbook comment, in which case it also needs "/**" at the beginning of the comment.
Thanx, Paul
> >> + * callbacks queued on this CPU (including those for which the source CPU's > >> + * IPIs might not have been received on this CPU yet). This is invoked by a > >> + * CPU about to go offline, to ensure that all pending IPI functions are run > >> + * before it goes completely offline. > >> + * > >> + * Loop through the call_single_queue and run all the queued functions. > >> + * Must be called with interrupts disabled. > >> + */ > > > > Other than that, looks good to me. > > > > Reviewed-by: Tejun Heo <tj@kernel.org> > > > > Thank you! > > Regards, > Srivatsa S. Bhat >
| |