lkml.org 
[lkml]   [2014]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: WARN in do_rt_tgsigqueueinfo()
On 05/15, Mateusz Guzik wrote:
>
> On Thu, May 15, 2014 at 11:54:15AM -0400, Dave Jones wrote:
> >
> > I'm of the opinion that a user-triggerable WARN is a bug, but aparently
> > not everyone else feels that way.

I didn't really like this WARN_ONCE() when I looked at the patch which
added it, but I didn't try to argue.

> imho warning sysadmins about userspace using deprecated stuff is fine as
> long as users are not able to spam the console with it.

Agreed,

> Warning reported here just looks scary and provides no information for
> sysadmins so I guess it hould be changed.

Again, agreed.

So imo we should either remove it, ot turn it into

pr_warn_once("something meaningful");

Oleg.



\
 
 \ /
  Last update: 2014-05-16 02:21    [W:3.219 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site