Messages in this thread | | | Date | Thu, 15 May 2014 06:24:55 +0200 | From | Manfred Spraul <> | Subject | Re: [PATCH 6/6] ipc/sem.c: make semctl(,,{GETNCNT,GETZCNT}) standard compliant |
| |
Hi Andrew,
On 05/15/2014 12:30 AM, Andrew Morton wrote: > On Wed, 14 May 2014 07:52:38 -0700 Davidlohr Bueso <davidlohr@hp.com> wrote: > >>> - semcnt = 0; >>> + BUG_ON(sop->sem_flg & IPC_NOWAIT); >>> + BUG_ON(sop->sem_op > 0); >> Hmm in light of Linus' recent criticism about randomly sprinkling >> BUG_ONs in the kernel I'm not sure we want this. Yes, all those calls >> are correct from a logical pov and should never occur, however, would >> WARN be more suitable instead? I don't know. > Well, this BUG_ON is so old that a decent approach would be to just > delete the thing, if only Manfred wasn't changing stuff. > > Yes, if we can reasonably warn-then-recover then I guess that's worth > doing. I'll update the series anyway, then I remove the BUG_ONs entirely: They are just debuging helpers, there is no need to keep them in the final code.
-- Manfred
| |