lkml.org 
[lkml]   [2014]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: wlan-ng: Fix sparse warnings
On Sun, Apr 13, 2014 at 10:09:49PM +0530, code@slynux.com wrote:
> From: Sarath Lakshman <sarathlakshman@slynux.com>

This doesn't match your From: line, why?

>
> Fixed missed declarations for few non-static functions.
>
> Signed-off-by: Sarath Lakshman <sarathlakshman@slynux.com>
> ---
> drivers/staging/wlan-ng/cfg80211.c | 1 +
> drivers/staging/wlan-ng/prism2mgmt.h | 6 ++++++
> 2 files changed, 7 insertions(+)
>
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> index f76f95c..662581c 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -1,4 +1,5 @@
> /* cfg80211 Interface for prism2_usb module */
> +#include "prism2mgmt.h"
>
>
> /* Prism2 channel/frequency/bitrate declarations */
> diff --git a/drivers/staging/wlan-ng/prism2mgmt.h b/drivers/staging/wlan-ng/prism2mgmt.h
> index 190d390..ad049ad 100644
> --- a/drivers/staging/wlan-ng/prism2mgmt.h
> +++ b/drivers/staging/wlan-ng/prism2mgmt.h
> @@ -60,6 +60,8 @@
> #ifndef _PRISM2MGMT_H
> #define _PRISM2MGMT_H
>
> +#include "hfa384x.h"
> +
> extern int prism2_reset_holdtime;
> extern int prism2_reset_settletime;
>
> @@ -109,4 +111,8 @@ void prism2sta_processing_defer(struct work_struct *data);
> void prism2sta_commsqual_defer(struct work_struct *data);
> void prism2sta_commsqual_timer(unsigned long data);
>
> +void prism2_connect_result(wlandevice_t *wlandev, u8 failed);
> +void prism2_disconnected(wlandevice_t *wlandev);
> +void prism2_roamed(wlandevice_t *wlandev);

What about the existing declarations of these functions? Shouldn't they
be removed?

thanks,

greg k-h


\
 
 \ /
  Last update: 2014-05-16 00:01    [W:0.099 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site