lkml.org 
[lkml]   [2014]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 5/6] exynos: cpuidle: do not allow cpuidle registration for Exynos5420
Hi Chander,

On 14.05.2014 10:03, Chander Kashyap wrote:
> Exynos5420 is big.Little Soc. It uses cpuidle-big-litle generic cpuidle driver.
> Hence do not allow exynos cpuidle driver registration for Exynos5420.
>
> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
> Signed-off-by: Chander Kashyap <k.chander@samsung.com>
> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> arch/arm/mach-exynos/cpuidle.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos/cpuidle.c
> index 3dd385e..807a386 100644
> --- a/arch/arm/mach-exynos/cpuidle.c
> +++ b/arch/arm/mach-exynos/cpuidle.c
> @@ -218,6 +218,9 @@ static int exynos_cpuidle_probe(struct platform_device *pdev)
> int cpu_id, ret;
> struct cpuidle_device *device;
>
> + if (soc_is_exynos5420())
> + return -ENODEV;
> +
> if (soc_is_exynos5250())
> exynos5_core_down_clk();
>
>

Why not put this in exynos.c in exynos_dt_machine_init(), so
exynos_cpuidle_init() is called only if not running on Exynos5420?

Best regards,
Tomasz


\
 
 \ /
  Last update: 2014-05-16 00:01    [W:0.112 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site