Messages in this thread | | | Date | Thu, 15 May 2014 23:57:39 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging/rtl8723au fix sparse warning in os_initfs.c |
| |
On Thu, May 15, 2014 at 10:43:34PM +0200, Konrad Zapalowicz wrote: > This commit fixes the following sparse warning: > > drivers/staging/rtl8723au/os_dep/os_intfs.c: > - 322:14: warning: restricted __be16 degrades to integer > > Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com> > --- > drivers/staging/rtl8723au/os_dep/os_intfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723au/os_dep/os_intfs.c b/drivers/staging/rtl8723au/os_dep/os_intfs.c > index 57eca7a..31a70af 100644 > --- a/drivers/staging/rtl8723au/os_dep/os_intfs.c > +++ b/drivers/staging/rtl8723au/os_dep/os_intfs.c > @@ -319,7 +319,7 @@ u16 rtw_recv_select_queue23a(struct sk_buff *skb) > > memcpy(ð_type, pdata + (ETH_ALEN << 1), 2); > switch (eth_type) { > - case htons(ETH_P_IP): > + case be16_to_cpu(htons(ETH_P_IP)):
You should be more careful. This would have just made the code buggy.
Anyway someone already cleaned up this code. You should be working against linux-next.
regards, dan carpenter
| |