lkml.org 
[lkml]   [2014]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 3/3] CPU hotplug, smp: Flush any pending IPI callbacks before CPU offline
On 05/16/2014 12:49 AM, Tejun Heo wrote:
> Hello,
>
> On Fri, May 16, 2014 at 12:44:13AM +0530, Srivatsa S. Bhat wrote:
>> /*
>> + * flush_smp_call_function_queue - Flush any pending smp-call-function
>
> Don't we need a blank line here?
>

Hmm? That sentence continues on the next line, hence I didn't add any blank
line there.

>> + * callbacks queued on this CPU (including those for which the source CPU's
>> + * IPIs might not have been received on this CPU yet). This is invoked by a
>> + * CPU about to go offline, to ensure that all pending IPI functions are run
>> + * before it goes completely offline.
>> + *
>> + * Loop through the call_single_queue and run all the queued functions.
>> + * Must be called with interrupts disabled.
>> + */
>
> Other than that, looks good to me.
>
> Reviewed-by: Tejun Heo <tj@kernel.org>
>

Thank you!

Regards,
Srivatsa S. Bhat



\
 
 \ /
  Last update: 2014-05-15 22:21    [W:1.300 / U:0.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site