Messages in this thread | | | Subject | Re: [PATCH 1/1] fs/hfsplus/wrapper.c: replace min/casting by min_t | From | Joe Perches <> | Date | Thu, 15 May 2014 11:52:58 -0700 |
| |
On Thu, 2014-05-15 at 19:05 +0200, Fabian Frederick wrote: > Also add * before function comments (it was not detected by > kernel-doc) [] > diff --git a/fs/hfsplus/wrapper.c b/fs/hfsplus/wrapper.c [] > @@ -234,7 +234,7 @@ reread: > sbi->alloc_blksz_shift = 0; > while ((blocksize >>= 1) != 0) > sbi->alloc_blksz_shift++;
Unrelated, but perhaps this while loop should use fls instead.
| |