Messages in this thread | | | Date | Thu, 15 May 2014 10:28:46 -0300 | Subject | Re: [PATCH] clk: divider: Fix table round up function | From | Fabio Estevam <> |
| |
Hi Mike,
On Wed, May 7, 2014 at 1:48 PM, Maxime COQUELIN <maxime.coquelin@st.com> wrote: > Commit 1d9fe6b97 ("clk: divider: Fix best div calculation for power-of-two and > table dividers") introduces a regression in its _table_round_up function. > > When the divider passed to this function is greater than the max divider > available in the table, this function returns table's max divider. > Problem is that it causes an infinite loop in clk_divider_bestdiv() because > _next_div() will never return a value greater than maxdiv. > > Instead of returning table's max divider, this patch returns INT_MAX. > > Reported-by: Fabio Estevam <festevam@gmail.com> > Reported-by: Shawn Guo <shawn.guo@freescale.com> > Tested-by: Fabio Estevam <festevam@gmail.com> > Cc: Mike Turquette <mike.turquette@linaro.org> > Signed-off-by: Maxime Coquelin <maxime.coquelin@st.com>
Any comments on this one? It does fix a regression.
| |