Messages in this thread | | | Date | Tue, 13 May 2014 00:12:37 -0700 | From | Cody P Schafer <> | Subject | Re: [PATCH] powerpc/pseries: relocate "config DTL" so KConfig nests properly |
| |
On 05/12/2014 11:23 PM, Michael Neuling wrote: >> powerpc/pseries: relocate "config DTL" so KConfig nests properly > > I don't know what that means. Can you describe it in more detail? >
So the "config DTL" refers to the configuration entry.
The "nests properly" refers to the indent that 'make menuconfig' shows when a config-option that depends on the config-option proceeding it.
In this case, moving config DTL up so it is below config PPC_SPLPAR means that menuconfig will show config DTL nicely indented right below config PPC_SPLPAR when PPC_SPLPAR is enabled.
To contrast that, right now if I enable PPC_SPLPAR in menuconfig, all I can immediately tell is that "something showed up further down the list where I wasn't looking", and I end up having to toggle the option a few times to figure out what showed up, or look at the KConfig to find out that config DTL depends on config PPC_SPLPAR.
Essentially, this enables menuconfig to provide a visual hint about the dependencies between options.
> Mikey > > > On Mon, 2014-05-12 at 20:09 -0700, Cody P Schafer wrote: >> Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com> >> --- >> arch/powerpc/platforms/pseries/Kconfig | 20 ++++++++++---------- >> 1 file changed, 10 insertions(+), 10 deletions(-) >> >> diff --git a/arch/powerpc/platforms/pseries/Kconfig b/arch/powerpc/platforms/pseries/Kconfig >> index 2cb8b77..e00dd4d 100644 >> --- a/arch/powerpc/platforms/pseries/Kconfig >> +++ b/arch/powerpc/platforms/pseries/Kconfig >> @@ -33,6 +33,16 @@ config PPC_SPLPAR >> processors, that is, which share physical processors between >> two or more partitions. >> >> +config DTL >> + bool "Dispatch Trace Log" >> + depends on PPC_SPLPAR && DEBUG_FS >> + help >> + SPLPAR machines can log hypervisor preempt & dispatch events to a >> + kernel buffer. Saying Y here will enable logging these events, >> + which are accessible through a debugfs file. >> + >> + Say N if you are unsure. >> + >> config PSERIES_MSI >> bool >> depends on PCI_MSI && PPC_PSERIES && EEH >> @@ -122,13 +132,3 @@ config HV_PERF_CTRS >> systems. 24x7 is available on Power 8 systems. >> >> If unsure, select Y. >> - >> -config DTL >> - bool "Dispatch Trace Log" >> - depends on PPC_SPLPAR && DEBUG_FS >> - help >> - SPLPAR machines can log hypervisor preempt & dispatch events to a >> - kernel buffer. Saying Y here will enable logging these events, >> - which are accessible through a debugfs file. >> - >> - Say N if you are unsure. >
| |