Messages in this thread | | | Date | Tue, 13 May 2014 08:59:36 +0200 | From | Thierry Reding <> | Subject | Re: [PATCH] pwm_lpss: Add support for PCI devices |
| |
On Mon, May 12, 2014 at 04:18:16PM -0700, Darren Hart wrote: > On Sat, Apr 12, 2014 at 09:58:51PM +0800, Chew Chiau Ee wrote: > > From: Alan Cox <alan@linux.intel.com> > > > > Not all systems enumerate the PWM devices via ACPI. They can also be exposed > > via the PCI interface. > > > > Signed-off-by: Alan Cox <alan@linux.intel.com> > > Signed-off-by: Chew, Chiau Ee <chiau.ee.chew@intel.com> > > --- > > drivers/pwm/pwm-lpss.c | 160 ++++++++++++++++++++++++++++++++++++++--------- > > 1 files changed, 129 insertions(+), 31 deletions(-) [...] > Has this landed anywhere? I didn't see it in mainline or next, am I looking in > the wrong place?
This was applied to the pwm/for-next tree and has been in linux-next since next-20140429.
> If it's just still pending, I ran into one issue integrating it > with 3.14.2: > > CC [M] drivers/pwm/pwm-lpss.o > drivers/pwm/pwm-lpss.c: In function ‘pwm_lpss_probe_pci’: > drivers/pwm/pwm-lpss.c:192:2: warning: passing argument 3 of ‘pwm_lpss_probe’ > discards ‘const’ qualifier from pointer target type [enabled by default] > drivers/pwm/pwm-lpss.c:130:30: note: expected ‘struct pwm_lpss_boardinfo *’ > but argument is of type ‘const struct pwm_lpss_boardinfo *’ > > Can we make the third argument to pwm_lpss_probe a const? The following is > working for me: > > static struct pwm_lpss_chip *pwm_lpss_probe(struct device *dev, > struct resource *r, > const struct pwm_lpss_boardinfo *info)
A fix like that was applied last week and is in next-20140512.
Thierry [unhandled content-type:application/pgp-signature] | |