Messages in this thread | | | Date | Mon, 12 May 2014 16:03:51 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 1/2] Add lib/glob.c |
| |
On Sat, 10 May 2014 08:21:38 -0400 Tejun Heo <tj@kernel.org> wrote:
> > +int > > +main(void) > > +{ > > + size_t i; > > + > > + for (i = 0; i < sizeof(tests)/sizeof(*tests); i++) > > + test(tests + i); > > + > > + return 0; > > +} > > + > > +#endif /* UNITTEST */ > > Again, I don't really think the userland testing code belongs here. > If you wanna keep them, please make it in-kernel selftesting. We > don't really wanna keep code which can't get built and tested in > kernel tree proper.
If the tests don't measurably increase boot times we could run them unconditionally at boot. Mark everything __init/__initdata and the costs are very low. lib/plist.c does this.
| |