lkml.org 
[lkml]   [2014]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] Add lib/glob.c
On Sat, 10 May 2014 08:21:38 -0400 Tejun Heo <tj@kernel.org> wrote:

> > +int
> > +main(void)
> > +{
> > + size_t i;
> > +
> > + for (i = 0; i < sizeof(tests)/sizeof(*tests); i++)
> > + test(tests + i);
> > +
> > + return 0;
> > +}
> > +
> > +#endif /* UNITTEST */
>
> Again, I don't really think the userland testing code belongs here.
> If you wanna keep them, please make it in-kernel selftesting. We
> don't really wanna keep code which can't get built and tested in
> kernel tree proper.

If the tests don't measurably increase boot times we could run them
unconditionally at boot. Mark everything __init/__initdata and
the costs are very low. lib/plist.c does this.


\
 
 \ /
  Last update: 2014-05-13 01:41    [W:0.134 / U:0.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site