Messages in this thread | | | Date | Mon, 12 May 2014 19:56:12 +0200 | From | Frederic Weisbecker <> | Subject | Re: [PATCH] sched,nohz: Change rq->nr_running always using wrappers |
| |
On Fri, May 09, 2014 at 03:00:14AM +0400, Kirill Tkhai wrote: > Sometimes nr_running may cross 2 but interrupt is not being > sent to rq's cpu. In this case we don't reenable timer. > Looks like, this may be a reason of rare unexpected effects, > if nohz is enabled. > > Patch replaces all places of direct changing of nr_running > and makes add_nr_running() caring about crossing border. > > Signed-off-by: Kirill Tkhai <tkhai@yandex.ru> > CC: Frederic Weisbecker <fweisbec@gmail.com> > CC: Peter Zijlstra <peterz@infradead.org> > CC: Ingo Molnar <mingo@kernel.org>
Right I had that issue with throttling in my TODO list.
Thanks for fixing that:
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
| |