lkml.org 
[lkml]   [2014]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers/hwmon/emc1403.c: add support for emc14x2
Hi Josef,

On Mon, May 12, 2014 at 02:34:09PM +0200, Josef Gajdusek wrote:
> Adds support for emc1402/emc1412/emc1422 temperature monitoring chips.
> This line of sensors does only have 2 channels (internal and external) in comparison to the emc14x3 (3 channels) and emc14x4 (4 channels) lines.
>
> Signed-off-by: Josef Gajdusek <atx@atx.name>

Applied, with a couple of minor adjustments.

> ---

[ ... ]
>
> static const unsigned short emc1403_address_list[] = {
> - 0x18, 0x29, 0x4c, 0x4d, I2C_CLIENT_END
> + 0x18, 0x29, 0x1c, 0x4c, 0x4d, 0x5c, I2C_CLIENT_END

Changed to numerical order.

> };
>
> +/* Last number in name indicates the amount of channels */

I found that comment a bit confusing, so I changed it to

/* Last digit of chip name indicates number of channels */

> static const struct i2c_device_id emc1403_idtable[] = {
> - { "emc1403", 0 },
> - { "emc1404", 1 },
> - { "emc1423", 0 },
> - { "emc1424", 1 },
> + { "emc1402", emc1402 },
> + { "emc1403", emc1403 },
> + { "emc1404", emc1404 },
> + { "emc1422", emc1402 },
> + { "emc1423", emc1403 },
> + { "emc1424", emc1404 },

Wonder if we should list the emc141x chips here. Jean, any thoughts ?

> { }
> };
> MODULE_DEVICE_TABLE(i2c, emc1403_idtable);
>

It would be nice to also have support for the alarms on EMC14x2,
but that can be a separate patch.

Thanks,
Guenter


\
 
 \ /
  Last update: 2014-05-12 19:01    [W:0.417 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site