lkml.org 
[lkml]   [2014]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] PM / suspend: Always use deepest C-state in the "freeze" sleep state
On 2014/5/12 22:08, Daniel Lezcano wrote:
> On 05/05/2014 12:51 AM, Rafael J. Wysocki wrote:
>> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>
>> If freeze_enter() is called, we want to bypass the current cpuidle
>> governor and always use the deepest available (that is, not disabled)
>> C-state, because we want to save as much energy as reasonably possible
>> then and runtime latency constraints don't matter at that point, since
>> the system is in a sleep state anyway.
>>
>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>> ---
>>
>> This is on top of https://patchwork.kernel.org/patch/4071541/ .
>>
>
> Wouldn't make sense to revisit play_dead instead ?
>
play_dead() is broken.

Even if it works, we still should rely on cpuidle driver to place the
CPUs into the deepest c-state, because there is no architectural way to
enter deepest c-state and what play_dead() does is a bad assumption.

Thanks,
-Aubrey



\
 
 \ /
  Last update: 2014-05-12 17:01    [W:0.073 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site