Messages in this thread | | | Date | Mon, 12 May 2014 10:09:08 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH] sched: Distinguish sched_wakeup event when wake up a task which did schedule out or not. |
| |
On Mon, 12 May 2014 08:47:30 +0200 Peter Zijlstra <peterz@infradead.org> wrote:
> But that has nothing what so fucking ever to do with 'success'. Reusing > that trace argument for something entirely different is just retarded.
And having a "success" field that his hard coded to "true" is also retarded. At least this change is fucking useful.
How about this. Add a new field called 'rq_added' or something. We can ever shrink the size of the "success" field and hard code it to true in the trace. That will never change. Then the caller of the tracepoint will send in a "true" or "false" to "rq_added" and we can add that tracepoint as well.
What I mean by shrink the size of the success field is that it is currently 4 bytes in size. We can make it two (or one) and then add another field for the 'rq_added' and have that be two bytes as well. This shouldn't break any tools that use this.
Point being, this is useful information, why not pass it to userspace?
-- Steve
| |