lkml.org 
[lkml]   [2014]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [patch 24/32] sh: intc: Remove pointless irq_reserve_irqs() invocation
    On Wed, May 07, 2014 at 03:44:18PM -0000, Thomas Gleixner wrote:
    > The preceding call to irq_create_identity_mapping() marks the
    > interrupt as allocated already. Remove the leftover.
    >
    > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    > Cc: linux-sh@vger.kernel.org
    > Cc: Simon Horman <horms@verge.net.au>

    This duplicates a similar patch, "[PATCH v3 2/8] sh, irq: Remove
    irq_reserve_irq calling", by Yinghai Lu. But perhaps you already know that.

    Regardless, I am fine with the contents.

    Acked-by: Simon Horman <horms+renesas@verge.net.au>

    > ---
    > drivers/sh/intc/core.c | 6 ------
    > 1 file changed, 6 deletions(-)
    >
    > Index: tip/drivers/sh/intc/core.c
    > ===================================================================
    > --- tip.orig/drivers/sh/intc/core.c
    > +++ tip/drivers/sh/intc/core.c
    > @@ -80,12 +80,6 @@ static void __init intc_register_irq(str
    > unsigned int data[2], primary;
    > unsigned long flags;
    >
    > - /*
    > - * Register the IRQ position with the global IRQ map, then insert
    > - * it in to the radix tree.
    > - */
    > - irq_reserve_irq(irq);
    > -
    > raw_spin_lock_irqsave(&intc_big_lock, flags);
    > radix_tree_insert(&d->tree, enum_id, intc_irq_xlate_get(irq));
    > raw_spin_unlock_irqrestore(&intc_big_lock, flags);
    >
    >


    \
     
     \ /
      Last update: 2014-05-11 11:21    [W:3.454 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site