lkml.org 
[lkml]   [2014]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3] rwsem: Support optimistic spinning
From
On Thu, May 1, 2014 at 9:39 AM, Tim Chen <tim.c.chen@linux.intel.com> wrote:
> On Wed, 2014-04-30 at 20:21 -0700, Davidlohr Bueso wrote:
>
>> +
>> +static inline bool rwsem_can_spin_on_owner(struct rw_semaphore *sem)
>> +{
>> + struct task_struct *owner;
>> + bool on_cpu = true;
>> +
>> + if (need_resched())
>> + return 0;
>> +
>> + rcu_read_lock();
>> + owner = ACCESS_ONCE(sem->owner);
>> + if (owner)
>> + on_cpu = owner->on_cpu;
>> + rcu_read_unlock();
>> +
>> + /*
>> + * If lock->owner is not set, the mutex owner may have
>> + * just acquired it and not set the owner yet or the mutex
>
> Nitpick. Change the above 2 mutex in comment to rwsem.

On that note, we may also change "lock->owner" to "sem->owner" for consistency.

Thanks,
Jason


\
 
 \ /
  Last update: 2014-05-01 23:01    [W:0.072 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site