Messages in this thread | | | Date | Wed, 09 Apr 2014 10:06:12 +0100 | From | "Jan Beulich" <> | Subject | Re: [XEN PATCH 1/2] hvm: Support more than 32 VCPUS when migrating. |
| |
>>> On 08.04.14 at 19:25, <konrad@kernel.org> wrote: > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -3470,6 +3470,9 @@ static long hvm_vcpu_op( > case VCPUOP_stop_singleshot_timer: > case VCPUOP_register_vcpu_info: > case VCPUOP_register_vcpu_time_memory_area: > + case VCPUOP_down: > + case VCPUOP_up: > + case VCPUOP_is_up:
This, if I checked it properly, leaves only VCPUOP_initialise, VCPUOP_send_nmi, and VCPUOP_get_physid disallowed for HVM. None of which look inherently bad to be used by HVM (but VCPUOP_initialise certainly would need closer checking), so I wonder whether either the wrapper shouldn't be dropped altogether or at least be converted from a white list approach to a black list one.
Jan
| |