Messages in this thread | | | Date | Wed, 9 Apr 2014 16:56:31 +0100 | From | Mark Brown <> | Subject | Re: [PATCH] ASoC: dapm: Add support for multi register mux |
| |
On Fri, Apr 04, 2014 at 05:12:10PM -0700, Arun Shamanna Lakshmi wrote: > 1. Modify soc_enum struct to handle pointers for reg and mask > 2. Add dapm get and put APIs for multi register one hot encoded mux > 3. Update snd_soc_dapm_update struct to support multiple reg update
If you've got several changes like this it's probably a sign that the change ought to be split into a patch series.
I'm still not seeing any handling of the issues with having invalid configurations written to the device during the process of carrying out multi register updates; I did raise this with one of the earlier versions but don't recall any response.
I also think I agree with Takashi on this one - trying to implement this without adding an abstraction for the control values is making the code more complex than it needs to be, all the conditional paths for _ONEHOT aren't pretty (and don't use switches which is the usual idiom for this stuff if it's not indirected via functions). [unhandled content-type:application/pgp-signature] | |