lkml.org 
[lkml]   [2014]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf stat: Don't print bogus data when one event is requested
On Thu, Mar 27, 2014 at 06:20:59PM -0400, Ramkumar Ramachandra wrote:
> When only the stalled-cycles-frontend event is requested:
>
> $ perf stat -e stalled-cycles-frontend -- git s
> ## acme...ram/acme
>
> Performance counter stats for 'git s':
>
> 326,947,423 stalled-cycles-frontend # 0.00% frontend cycles idle
>
> 0.363599976 seconds time elapsed
>
> The 0.00% frontend cycles idle comment in the output is totally bogus
> and misleading. Omit printing it here, as well as in the
> stalled-cycles-backend case.

hi,
I agree with the change, but the reason for 0% is not only that
'one' event was stated, but that 'cycles' event is missing in
measurement.

Please change your changelog accordingly, the change itself
looks ok.

thanks,
jirka


\
 
 \ /
  Last update: 2014-04-09 15:21    [W:0.066 / U:1.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site