Messages in this thread | | | Date | Wed, 9 Apr 2014 14:39:04 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging: speakup: fix misuse of kstrtol() in handle_goto() |
| |
On Wed, Apr 09, 2014 at 07:45:46PM +0900, Daeseok Youn wrote: > > A string of goto_buf has a number followed by x or y. > e.g. "3x" means move 3 lines down. > The kstrtol() returns an error(-EINVAL) with this string so > go_pos has unsigned a value of that error. > And also "*cp" has not expected value. >
Good catch. This was introduced when we changed the simple_strtoul() to kstrtol().
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Did you find this bug by testing or through reading the code?
regards, dan carpenter
| |