lkml.org 
[lkml]   [2014]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: speakup: fix misuse of kstrtol() in handle_goto()
On Wed, Apr 09, 2014 at 07:45:46PM +0900, Daeseok Youn wrote:
>
> A string of goto_buf has a number followed by x or y.
> e.g. "3x" means move 3 lines down.
> The kstrtol() returns an error(-EINVAL) with this string so
> go_pos has unsigned a value of that error.
> And also "*cp" has not expected value.
>

Good catch. This was introduced when we changed the simple_strtoul() to
kstrtol().

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

Did you find this bug by testing or through reading the code?

regards,
dan carpenter



\
 
 \ /
  Last update: 2014-04-09 14:21    [W:0.036 / U:1.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site