lkml.org 
[lkml]   [2014]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: driver skip pci_set_master, fix it? No.
From
Date
On Tue, 2014-04-08 at 17:18 -0400, Mark Lord wrote:
> > I assume you're talking about the one added by cf3e1feba7f9 ("PCI:
> > Workaround missing pci_set_master in pci drivers"), but as far as I
> > can tell, it only calls pci_set_master() for *bridge* devices. What
> > am I missing? Is pci_set_master() being called for your endpoint?
> > What path is that?
>
> Yes, it is being called during execution of the _probe() function in my driver,
> as evidenced by the annoying (and wrong) message it produces.
>
> Next time I've got the hardware at hand, I'll put a "dump_stack()" into there
> to see the exact calling path.

Note that one of the reason we want to do it early on bridges is that without it,
we may also not get the PCIe error messages.

Cheers,
Ben.




\
 
 \ /
  Last update: 2014-04-09 05:01    [W:0.077 / U:5.372 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site