lkml.org 
[lkml]   [2014]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] hugetlb: add support for gigantic page allocation at runtime
On Tue, 8 Apr 2014 15:51:02 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Mon, 7 Apr 2014 14:49:35 -0400 Luiz Capitulino <lcapitulino@redhat.com> wrote:
>
> > > > ---
> > > > arch/x86/include/asm/hugetlb.h | 10 +++
> > > > mm/hugetlb.c | 177 ++++++++++++++++++++++++++++++++++++++---
> > > > 2 files changed, 176 insertions(+), 11 deletions(-)
> > > >
> > > > diff --git a/arch/x86/include/asm/hugetlb.h b/arch/x86/include/asm/hugetlb.h
> > > > index a809121..2b262f7 100644
> > > > --- a/arch/x86/include/asm/hugetlb.h
> > > > +++ b/arch/x86/include/asm/hugetlb.h
> > > > @@ -91,6 +91,16 @@ static inline void arch_release_hugepage(struct page *page)
> > > > {
> > > > }
> > > >
> > > > +static inline int arch_prepare_gigantic_page(struct page *page)
> > > > +{
> > > > + return 0;
> > > > +}
> > > > +
> > > > +static inline void arch_release_gigantic_page(struct page *page)
> > > > +{
> > > > +}
> > > > +
> > > > +
> > > > static inline void arch_clear_hugepage_flags(struct page *page)
> > > > {
> > > > }
> > >
> > > These are defined only on arch/x86, but called in generic code.
> > > Does it cause build failure on other archs?
> >
> > Hmm, probably. The problem here is that I'm unable to test this
> > code in other archs. So I think the best solution for the first
> > merge is to make the build of this feature conditional to x86_64?
> > Then the first person interested in making this work in other
> > archs add the generic code. Sounds reasonable?
>
> These functions don't actually do anything so if and when other
> architectures come along to implement this feature, their developers
> won't know what you were thinking when you added them. So how about
> some code comments to explain their roles and responsibilities?
>
> Or just delete them altogether and let people add them (or something
> similar) if and when the need arises. It's hard to tell when one lacks
> telepathic powers, sigh.

That's exactly what I did for v2 (already posted).


\
 
 \ /
  Last update: 2014-04-09 03:21    [W:0.086 / U:11.004 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site