lkml.org 
[lkml]   [2014]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v10 1/1] Tracepoint: register/unregister struct tracepoint
On Tue, 8 Apr 2014 19:35:54 +0000 (UTC)
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:

> >
> > > +{
> > > + if (call->flags & TRACE_EVENT_FL_TRACEPOINT)
> > > + return call->tp ? call->tp->name : NULL;
> > > + else
> > > + return call->name;
> > > +}
> >
> > Also, you missed a bunch of conversions in trace_event.c file. Do a
> > search for '->name' and you'll find them. The ones that shouldn't be
> > converted are rather obvious (system, field, mod), but you'll see
> > others that were missed. I'm a bit nervous about what other ones may be
> > missed as well.
>
> Got them. I noticed that I forgot to turn on CONFIG_DYNAMIC_FTRACE when
> I did the original swap from name to _name to find the sites to update.
>
> I did test more recently with a config that has all the FTRACE and PERF
> features enabled, but that was after I swapped back from _name to name,
> so I did not catch those two sites.
>
> I just swapped the field name to _name again, and did the build with
> all FTRACE and PERF config options enabled to be certain I did not miss
> any. Just to be extra sure, I'm doing a make allyesconfig too.
>
> Then, I'm changing _name back to name, and I'll prepare this as v11.
>
> Is that OK with you ?
>

Maybe you want to build with an allmodconfig to make sure. You probably
did get everything, but just to be sure.

-- Steve


\
 
 \ /
  Last update: 2014-04-08 23:01    [W:0.039 / U:23.476 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site