lkml.org 
[lkml]   [2014]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Kbuild: move extra gcc check flags to the top Makefile
On Tue, Apr 08, 2014 at 05:06:57PM +0200, Michal Marek wrote:
> On 2014-04-07 05:22, Masahiro Yamada wrote:
> > If W=... given to the command line, extra gcc check flags are added
> > to KBUILD_CFLAGS.
> >
> > If we have such code in scripts/Makefile.build, the same flags are
> > added to KBUILD_CFLAGS multiple times becuase scripts/Makefile.build
> > is invoked every time Kbuild descends into the subdirectories.
>
> Indeed. For three years, nobody has noticed that the gcc commandline is
> growing with every subdirectory.
I once had a patchset that moved all this out - to avoid this.
It was lost for various reasons.

The top-level Makefile is already too cluttered - so adding all this
is not good.
Moving it all to a dedicated file would be better.

Sam


\
 
 \ /
  Last update: 2014-04-08 18:01    [W:0.039 / U:8.840 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site