lkml.org 
[lkml]   [2014]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 6/7] gpio: dwapb: use a second irq chip
From
On Mon, Apr 7, 2014 at 4:59 AM, Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:
> On 03/25/2014 10:36 PM, Sebastian Hesselbarth wrote:
>>> @@ -242,17 +244,28 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio,
>>> irq_gc->reg_base = gpio->regs;
>>> irq_gc->private = gpio;
>>>
>>> - ct = irq_gc->chip_types;
>>> - ct->chip.irq_ack = irq_gc_ack_set_bit;
>>> - ct->chip.irq_mask = irq_gc_mask_set_bit;
>>> - ct->chip.irq_unmask = irq_gc_mask_clr_bit;
>>> - ct->chip.irq_set_type = dwapb_irq_set_type;
>>> - ct->chip.irq_enable = dwapb_irq_enable;
>>> - ct->chip.irq_disable = dwapb_irq_disable;
>>> - ct->chip.irq_request_resources = dwapb_irq_reqres;
>>> - ct->chip.irq_release_resources = dwapb_irq_relres;
>>> - ct->regs.ack = GPIO_PORTA_EOI;
>>> - ct->regs.mask = GPIO_INTMASK;
>>> + for (i = 0; i < 2; i++) {
>>> +
>>> + ct = &irq_gc->chip_types[i];
>>> + ct->chip.irq_ack = irq_gc_ack_set_bit;
>>> + ct->chip.irq_mask = irq_gc_mask_set_bit;
>>> + ct->chip.irq_unmask = irq_gc_mask_clr_bit;
>>> + ct->chip.irq_set_type = dwapb_irq_set_type;
>>> + ct->chip.irq_enable = dwapb_irq_enable;
>>> + ct->chip.irq_disable = dwapb_irq_disable;
>>> + ct->chip.irq_request_resources = dwapb_irq_reqres;
>>> + ct->chip.irq_release_resources = dwapb_irq_relres;
>>> + ct->regs.ack = GPIO_PORTA_EOI;
>>> + ct->regs.mask = GPIO_INTMASK;
>>> +
>>> + if (i == 0) {
>>> + ct->type = IRQ_TYPE_LEVEL_MASK;
>>> + ct->handler = handle_level_irq;
>>> + } else {
>>> + ct->type = IRQ_TYPE_EDGE_BOTH;
>>> + ct->handler = handle_edge_irq;
>>> + }
>>
>> Sebastian,
>>
>> IMHO the loop looks strange, especially with the (i == 0) check.
>
> how so?
>
>> How about unrolling it again and assign both chip_types independently?
>
> If more code makes you happy so be it. I will post the series soon with
> the loop unrolled.
>
>> Sebastian
>
> Sebastian

You could keep the loop but take out the if (i==0). Set the type and
handler after the loop:

irq_gc->chip_types[0]->type = IRQ_TYPE_LEVEL_MASK;
irq_gc->chip_types[0]->handler = handle_level_irq;
irq_gc->chip_types[1]->type = IRQ_TYPE_EDGE_BOTH;
irq_gc->chip_types[1]->handler = handle_edge_irq;

Alan Tull
aka
delicious quinoa


\
 
 \ /
  Last update: 2014-04-08 18:01    [W:0.092 / U:6.836 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site