lkml.org 
[lkml]   [2014]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] checkpatch: fix wildcard DT compatible string checking
From
Date
On Tue, 2014-04-08 at 08:25 -0500, Rob Herring wrote:
> We attempt to search for compatible strings which use a variable
> token in the documented name such as <chip> or <soc>. While this
> was attempted to be handled, it's utterly broken.

Looks like you've left some debugging stuff in this patch.

> The desired forms of matching are:
>
> vendor,<chip>-*
> vendor,name<part#>-*

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 34eb216..0e960b1 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2093,8 +2093,11 @@ sub process {
>
> foreach my $compat (@compats) {
> my $compat2 = $compat;
> - $compat2 =~ s/\,[a-z]*\-/\,<\.\*>\-/;
> - `grep -Erq "$compat|$compat2" $dt_path`;
> + $compat2 =~ s/\,[a-zA-Z0-9]*\-/\,<\.\*>\-/;
> + my $compat3 = $compat;
> + $compat3 =~ s/\,([a-z]*)[0-9]*\-/\,$1<\.\*>\-/;
> + print "$compat3\n";

debugging code?

> + `grep -Erq "$compat|$compat2|$compat3" $dt_path`;
> if ( $? >> 8 ) {
> WARN("UNDOCUMENTED_DT_STRING",
> "DT compatible string \"$compat\" appears un-documented -- check $dt_path\n" . $herecurr);





\
 
 \ /
  Last update: 2014-04-08 17:21    [W:0.047 / U:6.920 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site