lkml.org 
[lkml]   [2014]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/15 V3] perf, c2c: Rework setup code to prepare for features
On Tue, Apr 08, 2014 at 04:41:29PM +0900, Namhyung Kim wrote:
> On Sat, 29 Mar 2014 18:10:18 +0100, Jiri Olsa wrote:
> > On Mon, Mar 24, 2014 at 03:36:56PM -0400, Don Zickus wrote:
> >
> > SNIP
> >
> >>
> >> static int perf_c2c__process_load_store(struct perf_c2c *c2c,
> >> + struct addr_location *al,
> >> struct perf_sample *sample,
> >> - struct addr_location *al)
> >> + struct perf_evsel *evsel)
> >> {
> >> - if (c2c->raw_records)
> >> - perf_sample__fprintf(sample, ' ', "raw input", al, stdout);
> >> + struct mem_info *mi;
> >> +
> >> + mi = sample__resolve_mem(sample, al);
> >> + if (!mi)
> >> + return -ENOMEM;
> >
> > perhaps not directly related to this patchset, but I needed
> > attached patch to get resolved data in .bss (static), which
> > for some reason happened to be located in executable segment
>
> Wasn't it a read-only/const data?

I believe it had the 'x' bit set. Or the kernel was not passing any
protection bits, so it defaulted to MAP_FUNCTION?

Cheers,
Don

>
> Hmm.. maybe we could copy the text map and add it to a variable map
> group if it has any variables in it..
>
> Thanks,
> Namhyung
>
> >
> > I wonder why we need this VARIABLE/FUNCTION separation at all,
> > I think Arnaldo told me some archs could have same addresses
> > for data and functions.. will check ;-)
> >
> > jirka
> >
> > ---
> > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
> > index d9d86c6..be6d7cf 100644
> > --- a/tools/perf/util/machine.c
> > +++ b/tools/perf/util/machine.c
> > @@ -1220,6 +1220,10 @@ static void ip__resolve_data(struct machine *machine, struct thread *thread,
> >
> > thread__find_addr_location(thread, machine, m, MAP__VARIABLE, addr,
> > &al);
> > + if (!al.map)
> > + thread__find_addr_location(thread, machine, m, MAP__FUNCTION, addr,
> > + &al);
> > +
> > ams->addr = addr;
> > ams->al_addr = al.addr;
> > ams->sym = al.sym;


\
 
 \ /
  Last update: 2014-04-08 17:01    [W:0.101 / U:38.552 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site