lkml.org 
[lkml]   [2014]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node
From
Date
On Tue, 2014-04-08 at 07:33 -0500, Timur Tabi wrote:
> Ivan T. Ivanov wrote:
> >> >I'm confused by this. Isn't this information already defined in the
> >> >pinctrl-msm8x74.c driver?
> >> >
> >> >static const char * const blsp_spi8_groups[] = {
> >> > "gpio45", "gpio46", "gpio47", "gpio48"
> >> >};
> > I am not sure that I understand the question. This is one of
> > possible ways to describe relationship between pins and functions.
> > As they are described is visible what is their real purpose.
>
> Ok, let me rephrase.
>
> The 8x74 pinctrl driver already contains this information. It already
> defines a "blsp_spi8" group consisting of GPIOs 45, 46, 47, and 48.
>
> This patch adds that same exact information into the device tree. Why
> are we duplicating that information? Why add it to the device tree when
> it's already in the driver (and already working).

Probably. It was my natural way of thinking. Pin have a functions.
It is easier if I measure signals to just look at the device
tree file. What are you suggesting?

>
> Also, I don't see any code anywhere that uses these new device tree nodes.

This is easy to fix :-).

Regards,
Ivan



\
 
 \ /
  Last update: 2014-04-08 16:21    [W:0.114 / U:2.148 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site