lkml.org 
[lkml]   [2014]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH V2 1/4] cpufreq: ia64: don't set .driver_data to index
Date
On Friday, March 28, 2014 07:11:44 PM Viresh Kumar wrote:
> .driver_data field is only required to be filled if drivers want to preserve
> some data in there which they can use according to the value of .frequency
> field. But this driver isn't using this field at all, but just setting it equal
> to the index value. Which isn't required. Fix it.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

All four queued up for the next pull request, thanks!

> ---
> V1->V2: No Change
>
> Hi Rafael,
>
> To avoid confusion I am sending all related cpufreq patches again.
>
> drivers/cpufreq/ia64-acpi-cpufreq.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/ia64-acpi-cpufreq.c b/drivers/cpufreq/ia64-acpi-cpufreq.c
> index a22b5d1..beb191b 100644
> --- a/drivers/cpufreq/ia64-acpi-cpufreq.c
> +++ b/drivers/cpufreq/ia64-acpi-cpufreq.c
> @@ -275,7 +275,6 @@ acpi_cpufreq_cpu_init (
> /* table init */
> for (i = 0; i <= data->acpi_data.state_count; i++)
> {
> - data->freq_table[i].driver_data = i;
> if (i < data->acpi_data.state_count) {
> data->freq_table[i].frequency =
> data->acpi_data.states[i].core_frequency * 1000;
>

--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.


\
 
 \ /
  Last update: 2014-04-08 14:41    [W:0.049 / U:3.488 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site